When running upgrade command, ignore errors upgrading sources if outside of a git repository #1196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you run the
qlty upgrade
command outside of a git directory it currently will perform the upgrade but then raise the following error:❌ This subcommand must be run within a Git repository.
Turns out this is because it is attempting to update sources, and updating sources requires being inside of a Git repository.
This PR prevents error propagation in this case, allowing source updating to occur within a Git repository, and otherwise allows the upgrade to complete successfully without an error message.