-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow plot_expected_purchases_pcc
in BetaGeoModel
and ModifiedBetaGeoModel
#1470
Allow plot_expected_purchases_pcc
in BetaGeoModel
and ModifiedBetaGeoModel
#1470
Conversation
…x ModifiedBetaGeoNBDRV sim_data
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1470 +/- ##
==========================================
- Coverage 92.58% 92.58% -0.01%
==========================================
Files 52 52
Lines 6045 6043 -2
==========================================
- Hits 5597 5595 -2
Misses 448 448 ☔ View full report in Codecov by Sentry. |
"alpha_prior": Prior("Weibull", alpha=2, beta=10), | ||
"r_prior": Prior("Weibull", alpha=2, beta=1), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change? (I'm not opposed, just curious.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to get your opinion on the default prior change in BetaGeoModel
, but otherwise this is good to merge!
I) If we use :
Then II) If we just modify those 2 but leave
Also, we should add an Issue to experiment with the default priors. |
Description
ModifiedBetaGeoNBDRV
internalsim_data
Related Issue
plot_expected_purchases_pcc
support to BG/NBD and MBG/NBD Models #1421Checklist
pre-commit.ci autofix
to auto-fix.📚 Documentation preview 📚: https://pymc-marketing--1470.org.readthedocs.build/en/1470/