Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ModifiedBetaGeoNBDRV sim_data #1472

Merged

Conversation

PabloRoque
Copy link
Contributor

@PabloRoque PabloRoque commented Feb 6, 2025

Description

Fixes sim_data in ModifiedBetaGeoNBDRV

  • Pre-fix behavior: pm.sample_prior_predictive | pm.sample_posterior_predictive would return 0 for recency | frequency vars.
  • Post-fix behavior: both methods return correct samples.

See lifetimes implementation for reference

Related Issue

Checklist


📚 Documentation preview 📚: https://pymc-marketing--1472.org.readthedocs.build/en/1472/

@github-actions github-actions bot added the CLV label Feb 6, 2025
@PabloRoque PabloRoque added the bug Something isn't working label Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.55%. Comparing base (4ef55f3) to head (12fac44).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1472   +/-   ##
=======================================
  Coverage   92.55%   92.55%           
=======================================
  Files          52       52           
  Lines        5947     5947           
=======================================
  Hits         5504     5504           
  Misses        443      443           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PabloRoque
Copy link
Contributor Author

Triggered pre-commit.ci - pr 3 times, but it keeps failing... Issues with mypy build timing out.

@PabloRoque PabloRoque requested a review from ColtAllen February 6, 2025 11:18
@PabloRoque PabloRoque enabled auto-merge (squash) February 6, 2025 14:23
@PabloRoque PabloRoque disabled auto-merge February 6, 2025 16:31
@PabloRoque PabloRoque merged commit 15793e2 into pymc-labs:main Feb 6, 2025
19 of 20 checks passed
@PabloRoque PabloRoque deleted the fix-sim-data-modifiedbetageo-RV branch February 6, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLV
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants