Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sdkv2 detailed diff tests #2816

Open
wants to merge 2 commits into
base: vvm/refactor_pf_detailed_diff_tests
Choose a base branch
from

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Jan 7, 2025

This PR refactors the SDKv2 detailed diff tests to make test sharding easier. The main problem was that TestDetailedDiffSet was too large. Very similar to what #2814 does for PF.

This PR:

  • Moves the SDKv2 detailed diff tests to their own folder. This should make sharing code between them easier without exposing it to the other tests.
  • Splits up TestDetailedDiffSet into a few separate tests. This will allow the tests to be run on different shards.
  • Moves around some of the shared code into the value_makers.go file, instead of duplicating in each test.
  • Renames the tests to specify that they are for SDKv2 and renamed some of the utility functions to clarify what they do.

2c18440 has test recordings, the rest are the changes. The test recording changes are all no-ops related to the change in the struct being recorded.

@VenelinMartinov VenelinMartinov changed the base branch from vvm/test_sharding to vvm/refactor_pf_detailed_diff_tests January 7, 2025 16:13
@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_sdkv2_detailed_diff_tests branch from 674db1c to 4f6a39f Compare January 7, 2025 16:13
@VenelinMartinov VenelinMartinov marked this pull request as draft January 7, 2025 16:18
@VenelinMartinov VenelinMartinov changed the title refactor sdkv2 detailed diff tests Refactor sdkv2 detailed diff tests Jan 7, 2025
@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_sdkv2_detailed_diff_tests branch from a381fb5 to 817019b Compare January 7, 2025 17:13
@VenelinMartinov VenelinMartinov force-pushed the vvm/refactor_sdkv2_detailed_diff_tests branch from 817019b to 2c18440 Compare January 7, 2025 17:16
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.63%. Comparing base (dbc1c2d) to head (2c18440).

Additional details and impacted files
@@                           Coverage Diff                           @@
##           vvm/refactor_pf_detailed_diff_tests    #2816      +/-   ##
=======================================================================
- Coverage                                68.63%   68.63%   -0.01%     
=======================================================================
  Files                                      325      325              
  Lines                                    41550    41550              
=======================================================================
- Hits                                     28519    28518       -1     
+ Misses                                   11426    11425       -1     
- Partials                                  1605     1607       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov marked this pull request as ready for review January 7, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant