-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor sdkv2 detailed diff tests #2816
Open
VenelinMartinov
wants to merge
2
commits into
vvm/refactor_pf_detailed_diff_tests
Choose a base branch
from
vvm/refactor_sdkv2_detailed_diff_tests
base: vvm/refactor_pf_detailed_diff_tests
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor sdkv2 detailed diff tests #2816
VenelinMartinov
wants to merge
2
commits into
vvm/refactor_pf_detailed_diff_tests
from
vvm/refactor_sdkv2_detailed_diff_tests
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is part of the following stack: Change managed by git-spice. |
This was referenced Jan 7, 2025
Open
VenelinMartinov
changed the base branch from
vvm/test_sharding
to
vvm/refactor_pf_detailed_diff_tests
January 7, 2025 16:13
VenelinMartinov
force-pushed
the
vvm/refactor_sdkv2_detailed_diff_tests
branch
from
January 7, 2025 16:13
674db1c
to
4f6a39f
Compare
VenelinMartinov
changed the title
refactor sdkv2 detailed diff tests
Refactor sdkv2 detailed diff tests
Jan 7, 2025
VenelinMartinov
force-pushed
the
vvm/refactor_sdkv2_detailed_diff_tests
branch
from
January 7, 2025 17:13
a381fb5
to
817019b
Compare
VenelinMartinov
force-pushed
the
vvm/refactor_sdkv2_detailed_diff_tests
branch
from
January 7, 2025 17:16
817019b
to
2c18440
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## vvm/refactor_pf_detailed_diff_tests #2816 +/- ##
=======================================================================
- Coverage 68.63% 68.63% -0.01%
=======================================================================
Files 325 325
Lines 41550 41550
=======================================================================
- Hits 28519 28518 -1
+ Misses 11426 11425 -1
- Partials 1605 1607 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the SDKv2 detailed diff tests to make test sharding easier. The main problem was that TestDetailedDiffSet was too large. Very similar to what #2814 does for PF.
This PR:
TestDetailedDiffSet
into a few separate tests. This will allow the tests to be run on different shards.value_makers.go
file, instead of duplicating in each test.2c18440 has test recordings, the rest are the changes. The test recording changes are all no-ops related to the change in the struct being recorded.