-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pb.Provider.ToProviderInfo test helper method #2805
base: master
Are you sure you want to change the base?
Conversation
This change is part of the following stack:
Change managed by git-spice. |
58a5829
to
d1f5261
Compare
cfb355c
to
b797040
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2805 +/- ##
==========================================
- Coverage 68.63% 68.59% -0.04%
==========================================
Files 325 325
Lines 41536 41550 +14
==========================================
- Hits 28507 28502 -5
- Misses 11423 11442 +19
Partials 1606 1606 ☔ View full report in Codecov by Sentry. |
b797040
to
c13c6e8
Compare
c13c6e8
to
380c0e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good. I think it would be easier to review if it was combined with #2812, since we could see both the new method and it's usage.
This PR adds a
ToProviderInfo
test helper method to theproviderbuilder
test class.providerbuilder
is the blessed way to build PF providers and we have various repeated code for turning this into a bridged providerProviderInfo
. The new method aims to consolidate them. This should also help with discoverability.