Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pb.Provider.ToProviderInfo test helper method #2805

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Jan 2, 2025

This PR adds a ToProviderInfo test helper method to the providerbuilder test class. providerbuilder is the blessed way to build PF providers and we have various repeated code for turning this into a bridged provider ProviderInfo. The new method aims to consolidate them. This should also help with discoverability.

@VenelinMartinov VenelinMartinov marked this pull request as draft January 2, 2025 15:36
@VenelinMartinov VenelinMartinov force-pushed the move-providerbuilder-to-pkg-pf branch from 58a5829 to d1f5261 Compare January 2, 2025 15:38
@VenelinMartinov VenelinMartinov force-pushed the vvm/add_to_provider_info_helper branch from cfb355c to b797040 Compare January 2, 2025 15:38
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 68.59%. Comparing base (2150faf) to head (380c0e9).

Files with missing lines Patch % Lines
pkg/pf/internal/providerbuilder/build_provider.go 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2805      +/-   ##
==========================================
- Coverage   68.63%   68.59%   -0.04%     
==========================================
  Files         325      325              
  Lines       41536    41550      +14     
==========================================
- Hits        28507    28502       -5     
- Misses      11423    11442      +19     
  Partials     1606     1606              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from move-providerbuilder-to-pkg-pf to master January 2, 2025 17:11
@VenelinMartinov VenelinMartinov force-pushed the vvm/add_to_provider_info_helper branch from b797040 to c13c6e8 Compare January 3, 2025 11:04
@VenelinMartinov VenelinMartinov force-pushed the vvm/add_to_provider_info_helper branch from c13c6e8 to 380c0e9 Compare January 7, 2025 11:34
@VenelinMartinov VenelinMartinov changed the title Add pb.Provider.ToProviderInfo helper method Add pb.Provider.ToProviderInfo test helper method Jan 7, 2025
@VenelinMartinov VenelinMartinov marked this pull request as ready for review January 7, 2025 13:54
@VenelinMartinov VenelinMartinov requested a review from t0yv0 January 7, 2025 18:42
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. I think it would be easier to review if it was combined with #2812, since we could see both the new method and it's usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants