-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PF integration tests using pulumitest #2186
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2186 +/- ##
==========================================
- Coverage 60.61% 59.84% -0.77%
==========================================
Files 356 356
Lines 46368 46311 -57
==========================================
- Hits 28104 27715 -389
- Misses 16706 17042 +336
+ Partials 1558 1554 -4 ☔ View full report in Codecov by Sentry. |
VenelinMartinov
changed the title
PF integration tests
PF integration tests using pulumitest
Jul 16, 2024
iwahbe
approved these changes
Jul 16, 2024
t0yv0
approved these changes
Jul 17, 2024
This was referenced Jul 17, 2024
VenelinMartinov
added a commit
that referenced
this pull request
Jul 23, 2024
This adds a few additions to the PF test utils: - Adds an option to buildprovider for tests to provide an import function - Adds `UseStateForUnknown` planmodifier to the id property in Create, as that seems to be used almost universally in pf providers in the `bridgedProvider` util - Adds a default Update implementation in the `bridgedProvider` util Stacked on #2186
This PR has been shipped in release v3.88.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some utility functions which allow simple integration testing in the PF bridge, similar to the tests in pkg:
pulumi-terraform-bridge/pkg/tests/schema_pulumi_test.go
Line 19 in f317dc4
Builds on
pulumitest
, theproviderbuilder
tools and thepulcheck
code underpkg
originally adapted from the cross tests.Allows integration tests to be written against PF, where the schema and the yaml program are specified concisely in the test and pulumitest is used for the actions which allows quite a bit of freedom in expressing pulumi operations.