-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PF tests add default update and import to buildprovider #2215
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2215 +/- ##
==========================================
- Coverage 60.66% 60.66% -0.01%
==========================================
Files 356 356
Lines 46430 46435 +5
==========================================
+ Hits 28169 28170 +1
- Misses 16701 16704 +3
- Partials 1560 1561 +1 ☔ View full report in Codecov by Sentry. |
r.ResourceSchema.Attributes["id"] = rschema.StringAttribute{ | ||
Computed: true, | ||
PlanModifiers: []planmodifier.String{ | ||
stringplanmodifier.UseStateForUnknown(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
This PR has been shipped in release v3.88.0. |
This adds a few additions to the PF test utils:
UseStateForUnknown
planmodifier to the id property in Create, as that seems to be used almost universally in pf providers in thebridgedProvider
utilbridgedProvider
utilStacked on #2186