Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PF tests add default update and import to buildprovider #2215

Merged
merged 7 commits into from
Jul 23, 2024

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Jul 21, 2024

This adds a few additions to the PF test utils:

  • Adds an option to buildprovider for tests to provide an import function
  • Adds UseStateForUnknown planmodifier to the id property in Create, as that seems to be used almost universally in pf providers in the bridgedProvider util
  • Adds a default Update implementation in the bridgedProvider util

Stacked on #2186

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 60.66%. Comparing base (c57aebd) to head (cb7a40c).
Report is 1 commits behind head on master.

Files Patch % Lines
...f/tests/internal/providerbuilder/build_resource.go 0.00% 5 Missing ⚠️
pf/tests/util.go 70.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2215      +/-   ##
==========================================
- Coverage   60.66%   60.66%   -0.01%     
==========================================
  Files         356      356              
  Lines       46430    46435       +5     
==========================================
+ Hits        28169    28170       +1     
- Misses      16701    16704       +3     
- Partials     1560     1561       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from vvm/pf_integration_tests to master July 22, 2024 09:06
r.ResourceSchema.Attributes["id"] = rschema.StringAttribute{
Computed: true,
PlanModifiers: []planmodifier.String{
stringplanmodifier.UseStateForUnknown(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@VenelinMartinov VenelinMartinov merged commit 6796105 into master Jul 23, 2024
11 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/pf_tests_fixups branch July 23, 2024 04:49
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.88.0.

@mjeffryes mjeffryes added this to the 0.108 milestone Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants