Adding support for secrets in all values in DeploymentSettings #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
IaroslavTitov
force-pushed
the
iaro/secrets
branch
6 times, most recently
from
21a754d to
50bc90f
Compare
IaroslavTitov
force-pushed
the
iaro/secrets
branch
from
50bc90f to
1f3eee9
Compare
komalali
approved these changes
Dec 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
=====================================
Coverage ? 0
=====================================
Files ? 0
Lines ? 0
Branches ? 0
=====================================
Hits ? 0
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
This was referenced Dec 12, 2024
Closed
IaroslavTitov
added a commit
that referenced
this pull request
Dec 13, 2024
### Summary - Fixes: #447 (kinda) - The reason secret was failing to create is due to this c# specific bug - pulumi/pulumi-dotnet#22 - A secret among env vars made the whole object secret and it was skipped - Recent change #467 actually made the issue worse - it is creating the env vars, but NOT secret (Thankfully I never released after that PR! 😅 ) - This PR adds cascading logic to envVars and username values - they are the only ones that are optionally secret ### Testing - Manual test
|
This PR has been shipped in release v0.27.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing