Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add secret support to all fiels #468

Open
IaroslavTitov opened this issue Dec 10, 2024 · 0 comments
Open

Add secret support to all fiels #468

IaroslavTitov opened this issue Dec 10, 2024 · 0 comments
Labels
kind/enhancement Improvements or new features

Comments

@IaroslavTitov
Copy link
Contributor

IaroslavTitov commented Dec 10, 2024 •
edited
Loading

Summary

  • All fields should support being passed in as secrets
  • For most resources we can just use MarshalingOptions that remove secrets, but some resources need to keep secrets
  • See PR Adding support for secrets in all values in DeploymentSettings #467 for example
  • Go through and make all resources that need to KeepSecrets when unmarshaling support secrets for all values
@IaroslavTitov IaroslavTitov added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team and removed needs-triage Needs attention from the triage team labels Dec 10, 2024
@IaroslavTitov IaroslavTitov mentioned this issue Dec 10, 2024
Merged
IaroslavTitov added a commit that referenced this issue Dec 12, 2024
@IaroslavTitov
Adding support for secrets in all values in DeploymentSettings (#467)
49003fc 
### Summary
- Adding support for all values in Deployment Settings to be read in as
secrets
- Cut ticket #468
to implement the same for ALL resources
- Added some folders to .gitignore that were getting created after
.ci-mgmt onboarding
- Added some digits to TemplateSource examples to remove flakiness

### Testing
- Manual test
- Edited integ test to test secret support every time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Improvements or new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@IaroslavTitov