Fix NodeJS metadata type #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blampe
commented
Nov 12, 2024
Comment on lines
+277
to
+278
| assert.Contains(t, string(testResource), "public readonly metadata!: pulumi.Output<outputs.meta.v1.ObjectMeta>;", "expected metadata output type") | ||
| assert.Contains(t, string(testResource), "metadata?: pulumi.Input<inputs.meta.v1.ObjectMeta>;", "expected metadata input type") |
There was a problem hiding this comment.
These were previously pulumi.Output<ObjectMeta> and pulumi.Input<ObjectMeta> respectively.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #159 +/- ##
==========================================
- Coverage 78.56% 75.98% -2.58%
==========================================
Files 17 17
Lines 723 966 +243
==========================================
+ Hits 568 734 +166
- Misses 87 163 +76
- Partials 68 69 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of our languages except NodeJS use
SchemaPackageWithObjectMetaType. As a result, Node exposes only input types for object metadata which makes it awkward to consume downstream.I'm assuming #143 didn't change this for backwards-compatibility reasons, or maybe it was overlooked. I think it is safe to continue generating the
ObjectMetatype alias (in case users are importing it) but use the input/output types (matching the upstream k8s types) on resources.Edit:
So this seems intentional. For whatever reason, using this with Node has the effect of generating input/output types matching upstream's types, which seems desirable.
Fixes #158