Fix type for generated resource metadata fields in NodeJS. #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corrects the type used for the metadata field in generated custom resources to use the output variant of ObjectMeta, allowing for simpler plumbing of metadata outputs, such as the resource name, into inputs of other resources.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #157 +/- ##
==========================================
- Coverage 78.56% 77.44% -1.12%
==========================================
Files 17 17
Lines 723 980 +257
==========================================
+ Hits 568 759 +191
- Misses 87 153 +66
Partials 68 68 ☔ View full report in Codecov by Sentry. |
|
Thank you for the pull request! I made some changes and will continue working on it here #159 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the type used for the metadata field in generated custom resources to use the output variant of ObjectMeta, allowing for simpler plumbing of metadata outputs, such as the resource name, into inputs of other resources.