Fix static initialization order fiasco in velox #24458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This pull request was exported from Phabricator. Differential Revision: D68857074 |
mkatsevVR
added a commit
to mkatsevVR/velox
that referenced
this pull request
Jan 31, 2025
) Summary: X-link: prestodb/presto#24458 Replace global statics with local to avoid non-determinism https://en.cppreference.com/w/cpp/language/siof Differential Revision: D68857074
mkatsevVR
added a commit
to mkatsevVR/presto
that referenced
this pull request
Jan 31, 2025
Summary: X-link: facebookincubator/velox#12204 Replace global statics with local to avoid non-determinism https://en.cppreference.com/w/cpp/language/siof Differential Revision: D68857074
mkatsevVR
force-pushed
the
export-D68857074
branch
from
42e0de3 to
8d66353
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68857074 |
mkatsevVR
added a commit
to mkatsevVR/presto
that referenced
this pull request
Jan 31, 2025
Summary: X-link: facebookincubator/velox#12204 Replace global statics with local to avoid non-determinism https://en.cppreference.com/w/cpp/language/siof Differential Revision: D68857074
mkatsevVR
force-pushed
the
export-D68857074
branch
from
8d66353 to
d07e05a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68857074 |
majetideepak
approved these changes
Jan 31, 2025
|
This pull request was exported from Phabricator. Differential Revision: D68857074 |
mkatsevVR
force-pushed
the
export-D68857074
branch
from
d07e05a to
719bfe2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebookincubator/velox#12204
Replace global statics with local to avoid non-determinism
https://en.cppreference.com/w/cpp/language/siof
AddressSanitizer: initialization-order-fiasco fbcode/velox/common/memory/Memory.cpp:381 in facebook::velox::memory::deprecatedDefaultMemoryManager()