Made changes regarding GitHub reviews

prebid · Feb 20, 2025 · eece8b6 · eece8b6
1 parent 025a574
commit eece8b6
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/adapters/pixfuture/pixfuture.go b/adapters/pixfuture/pixfuture.go
@@ -26,7 +26,10 @@ func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server co
 
 // MakeRequests prepares and serializes HTTP requests to be sent to the Pixfuture endpoint.
 func (a *adapter) MakeRequests(bidRequest *openrtb2.BidRequest, reqInfo *adapters.ExtraRequestInfo) ([]*adapters.RequestData, []error) {
-	var errs []error
+
+	if len(bidRequest.Imp) == 0 {
+		return nil, []error{errors.New("no impressions in bid request")}
+	}
 
 	// Create the outgoing request
 	body, err := jsonutil.Marshal(bidRequest)

diff --git a/adapters/pixfuture/pixfuture_test.go b/adapters/pixfuture/pixfuture_test.go
@@ -28,7 +28,7 @@ func TestAdapter_MakeRequests(t *testing.T) {
 				{
 					ID:     "test-imp-id",
 					Banner: &openrtb2.Banner{W: int64Ptr(300), H: int64Ptr(250)},
-					Ext:    jsonRawExt(`{"bidder":{"siteId":"123"}}`),
+					Ext:    json.RawMessage(`{"bidder":{"siteId":"123", "placementId":"456"}}`),
 				},
 			},
 		}

diff --git a/openrtb_ext/imp_pixfuture.go b/openrtb_ext/imp_pixfuture.go
@@ -1,5 +1,6 @@
 package openrtb_ext
 
 type ImpExtPixfuture struct {
-	PixID string `json:"pix_id"`
+	SiteID      string `json:"siteId"`
+	PlacementID string `json:"placementId"`
 }