Made changes regarding GitHub reviews

prebid · Feb 14, 2025 · 025a574 · 025a574
1 parent f1b859c
commit 025a574
Show file tree

Hide file tree

Showing 9 changed files with 18 additions and 61 deletions.
diff --git a/adapters/pixfuture/pixfuture.go b/adapters/pixfuture/pixfuture.go
@@ -28,28 +28,10 @@ func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server co
 func (a *adapter) MakeRequests(bidRequest *openrtb2.BidRequest, reqInfo *adapters.ExtraRequestInfo) ([]*adapters.RequestData, []error) {
 	var errs []error
 
-	// Process impressions
-	var validImpressions []openrtb2.Imp
-	for i := range bidRequest.Imp {
-		imp := &bidRequest.Imp[i]
-		if imp.Banner == nil && imp.Video == nil {
-			errs = append(errs, fmt.Errorf("unsupported impression type for impID: %s", imp.ID))
-			continue
-		}
-		validImpressions = append(validImpressions, *imp)
-	}
-
-	if len(validImpressions) == 0 {
-		errs = append(errs, errors.New("no valid impressions after filtering"))
-		return nil, errs
-	}
-
 	// Create the outgoing request
-	bidRequest.Imp = validImpressions
 	body, err := jsonutil.Marshal(bidRequest)
 	if err != nil {
-		errs = append(errs, fmt.Errorf("failed to marshal bid request: %w", err))
-		return nil, errs
+		return nil, []error{fmt.Errorf("failed to marshal bid request: %w", err)}
 	}
 
 	request := &adapters.RequestData{
@@ -61,7 +43,7 @@ func (a *adapter) MakeRequests(bidRequest *openrtb2.BidRequest, reqInfo *adapter
 		},
 	}
 
-	return []*adapters.RequestData{request}, errs
+	return []*adapters.RequestData{request}, nil
 }
 
 // getMediaTypeForBid extracts the bid type based on the bid extension data.

diff --git a/...etest/supplemental/bid_parsing_error.json → ...etest/supplemental/bid-parsing-error.json b/...etest/supplemental/bid_parsing_error.json → ...etest/supplemental/bid-parsing-error.json
diff --git a/...uretest/supplemental/empty_seatb_bid.json → ...uretest/supplemental/empty-seatb-bid.json b/...uretest/supplemental/empty_seatb_bid.json → ...uretest/supplemental/empty-seatb-bid.json
diff --git a/...uretest/supplemental/invalid_request.json → ...uretest/supplemental/invalid-request.json b/...uretest/supplemental/invalid_request.json → ...uretest/supplemental/invalid-request.json
diff --git a/...upplemental/no_content_response__204.json → ...supplemental/no-content-response-204.json b/...upplemental/no_content_response__204.json → ...supplemental/no-content-response-204.json
diff --git a/...st/supplemental/response_status_code.json → ...st/supplemental/response-status-code.json b/...st/supplemental/response_status_code.json → ...st/supplemental/response-status-code.json
diff --git a/coverage.out b/coverage.out
diff --git a/openrtb_ext/imp_pixfuture.go b/openrtb_ext/imp_pixfuture.go
@@ -1,5 +1,5 @@
 package openrtb_ext
 
 type ImpExtPixfuture struct {
-	PlacementID string `json:"pix_id"`
+	PixID string `json:"pix_id"`
 }
diff --git a/static/bidder-params/pixfuture.json b/static/bidder-params/pixfuture.json
@@ -1,16 +1,16 @@
 {
-    "$schema": "http://json-schema.org/draft-04/schema#",
-    "title": "PixFuture Adapter Params",
-    "description": "A schema which validates params accepted by the PixFuture adapter",
-    "type": "object",
-     "properties": {
-      "pix_id": {
-        "type": "string",
-        "description": "PixFuture placement ID",
-	"minLength": 3
-      }
-    },
-    
-    "required": ["pix_id"]
-  }
-  
+  "$schema": "http://json-schema.org/draft-04/schema#",
+  "title": "PixFuture Adapter Params",
+  "description": "A schema which validates params accepted by the PixFuture adapter",
+  "type": "object",
+  "properties": {
+    "pix_id": {
+      "type": "string",
+      "description": "PixFuture placement ID",
+      "minLength": 3
+    }
+  },
+  "required": [
+    "pix_id"
+  ]
+}