Hide Player Settings when in Skin Editor #31050
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the player settings overlays over the player, instead of moving around items (see before).
This now hides the player settings when in the skin editor, to prevent overlaying what the user is trying to edit.
Before #30749
osu._Huyuo6oGc5.mp4
(I didn't know this until recording, but the player settings were unusable in the skin editor anyways)
After #30749
osu._MYLiUXIfdW.mp4
After This PR
osu._4c13n6MsFM.mp4
I'll admit, I have a feeling it's not best practice in this repo to add a new
PlayerConfiguration
property for this. I'll watch and learn if there's changes.