Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Player Settings when in Skin Editor #31050

Closed
wants to merge 2 commits into from

Conversation

zacwm
Copy link
Contributor

@zacwm zacwm commented Dec 10, 2024

Now that the player settings overlays over the player, instead of moving around items (see before).

This now hides the player settings when in the skin editor, to prevent overlaying what the user is trying to edit.

Before #30749

osu._Huyuo6oGc5.mp4

(I didn't know this until recording, but the player settings were unusable in the skin editor anyways)

After #30749

osu._MYLiUXIfdW.mp4

After This PR

osu._4c13n6MsFM.mp4

I'll admit, I have a feeling it's not best practice in this repo to add a new PlayerConfiguration property for this. I'll watch and learn if there's changes.

im still unsure of the use of adding a property in `PlayerConfiguration`
@bdach
Copy link
Collaborator

bdach commented Dec 10, 2024

This PR only says what it says it does if you push an EndlessPlayer, which happens only when opening the skin editor from main menu. It does not work when you manually enter a ReplayPlayer and then open the skin editor.

Just based off that alone I'd say that this PR is not salvageable and thus does not warrant further review, so I see little point in keeping it open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants