Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide player settings overlay in skin editor #31104

Closed
wants to merge 2 commits into from

Conversation

SailorSnoW
Copy link

Fixes #31088.

This change introduces a new flag in the PlayerConfiguration to allow disabling the settings overlay in certain contexts (e.g., within the Skin Editor). This new flag ensures that the default behavior, as it was previously used, remains intact unless explicitly specified to disable the overlay.

In the Skin Editor, the settings overlay can interfere with the user experience when modifying components on the right side of the screen. Additionally, there should be no need to adjust the settings since the primary focus is simply on gameplay, which showcases the skin.

This change have also been made to the Skin Editor Test Scene.

@SailorSnoW SailorSnoW marked this pull request as draft December 13, 2024 01:12
@SailorSnoW SailorSnoW marked this pull request as ready for review December 13, 2024 01:36
@bdach
Copy link
Collaborator

bdach commented Dec 13, 2024

Functionally the same diff as #31050, and suffers from the exact same shortcoming.

@bdach bdach closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not show view settings in the skin editor
2 participants