[Session, Test] Session rollover test

[red-0ne]

Summary

AI Summary

Summary generated by Reviewpad on 26 Jan 24 05:42 UTC

This pull request includes changes to the relayerproxy.go file in the testproxy package. It involves the following changes:

• The function WithRelayerProxyDependencies has been renamed to WithRelayerProxyDependenciesForBlockHeight. It now takes an additional parameter blockHeight, which represents the block height returned by the block client's LastNBlock method.

• A new function WithSuccessiveSessions has been introduced. This function creates sessions with session numbers ranging from 0 to sessionsCount-1 and adds them to the session map. These sessions are configured with the same service ID and application provided.

• There is a TODO_TECHDEBT comment pertaining to suggested changes for the GetRelayResponseError function.

Issue

• [Protocol] Implement Session Rollovers #275

Type of change

Select one or more:

• New feature, functionality or library
• Bug fix
• Code health or cleanup
• Documentation
• Other (specify)

Testing

• Run all unit tests: make go_develop_and_test
• Run E2E tests locally: make test_e2e
• Run E2E tests on DevNet: Add the devnet-test-e2e label to the PR. This is VERY expensive, only do it after all the reviews are complete.

Sanity Checklist

• I have tested my changes using the available tooling
• I have performed a self-review of my own code
• I have commented my code, updated documentation and left TODOs throughout the codebase

[Olshansk]

A couple minor NITS but shold be g2g right after.

@red-0ne Remember to update the base branch to main assuming you'll merge the other one in first. Please also trigger e2e tests after.

[Olshansk]

This is an ultra NIT, but something I'm asking for just because I also always get confused between proxy/server/etc...

Do the key and proxyName need to be the same or can they be different?

[red-0ne]

You are right, it's confusing.

The key and ProxyName have to be the same, as the config parser maps the proxy servers using their ProxyName as keys.

I was uncomfortable having a variable as a key but afterthought, I believe it will add more clarity. Let's having as

defaultProxyServer: {
  ProxyName: defaultProxyServer,
  ...
}

[github-actions]

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. If you just created a pull request, you might need to push another commit to produce a container image DevNet can utilize to spin up infrastructure. You can use make trigger_ci to push an empty commit.