-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Protocol] Implement Session Rollovers #275
Comments
tl;dr In + session, err := rp.sessionQuerier.GetSession(ctx, appAddress, service.Id, relayRequest.Meta.SessionHeader.SessionStartBlockHeight)
- currentBlock := rp.blockClient.LastNBlocks(ctx, 1)[0]
- session, err := rp.sessionQuerier.GetSession(ctx, appAddress, service.Id, currentBlock.Height()) While implementing the quickstart guide in #252, the change above was necessary to make things work E2E because the session was ending too quickly. Until session rollovers are implemented, we can potentially run into bugs / issues in local development as well. The solution is to either:
|
Initial investigation and solution proposal https://www.notion.so/buildwithgrove/Sessions-rollover-f2845bd812c24b9c98934ca510bb70e9 |
Reviewed! Overall, the idea I had in mind was a little different. Only copy-pasting the mermaid diagram here for reference: CCing @bryanchriswhite since this may be dependant on the work in #141 (comment) |
Objective
Resolve the infamous session rollover issue once and for all
Origin Document
While working on #252, we had to add a temporary hack below due to:
Overall, this is us hitting the session rollover issue in Shannon
Goals
Deliverables
Non-goals / Non-deliverables
General deliverables
Creator: @Olshansk
Co-Owners: @red-0ne
The text was updated successfully, but these errors were encountered: