Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tokenomics] SettleSessionAccounting first implementation (emissions=burn) #323

Merged
merged 68 commits into from
Feb 2, 2024

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented Jan 16, 2024

Summary

Implement SettleSessionAccounting where emissions=burn.

Issue

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Run all unit tests: make go_develop_and_test
  • Run E2E tests locally: make test_e2e
  • Run E2E tests on DevNet: Add the devnet-test-e2e label to the PR. This is VERY expensive, only do it after all the reviews are complete.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have performed a self-review of my own code
  • I have commented my code, updated documentation and left TODOs throughout the codebase

@Olshansk Olshansk added on-chain On-chain business logic tokenomics Token Economics - what else do you need? labels Jan 16, 2024
@Olshansk Olshansk self-assigned this Jan 16, 2024
@Olshansk Olshansk added this to the Shannon TestNet milestone Jan 16, 2024
@Olshansk Olshansk requested a review from h5law January 24, 2024 22:17
@Olshansk
Copy link
Member Author

@h5law This is still not fully ready to be merged in (some TODOs, etc) but wnt to get the other issues / discussions resolved in parallel.

@Olshansk Olshansk force-pushed the issues/243/settle_session_accounting_implementation branch from 77575d9 to 40a21f2 Compare February 1, 2024 22:39
@Olshansk Olshansk requested a review from red-0ne February 2, 2024 17:20
Copy link
Contributor

@red-0ne red-0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some NIT comments but approving.

Great to see we have this working finally!

testutil/keeper/tokenomics.go Show resolved Hide resolved
x/tokenomics/keeper/settle_session_accounting_test.go Outdated Show resolved Hide resolved
x/tokenomics/keeper/settle_session_accounting_test.go Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Feb 2, 2024

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. If you just created a pull request, you might need to push another commit to produce a container image DevNet can utilize to spin up infrastructure. You can use make trigger_ci to push an empty commit.

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Feb 2, 2024
@Olshansk Olshansk merged commit 5a72be6 into main Feb 2, 2024
10 checks passed
@Olshansk Olshansk deleted the issues/243/settle_session_accounting_implementation branch February 2, 2024 23:27
@bryanchriswhite bryanchriswhite removed push-image CI related - pushes images to ghcr.io devnet-test-e2e labels May 16, 2024
@github-actions github-actions bot removed the devnet label May 16, 2024
okdas added a commit that referenced this pull request Nov 14, 2024
…burn) (#323)

Implement `SettleSessionAccounting` where emissions=burn.

- Issue: #243 

---

Co-authored-by: Redouane Lakrache <[email protected]>
Co-authored-by: Dima Kniazev <[email protected]>
Co-authored-by: Bryan White <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-chain On-chain business logic tokenomics Token Economics - what else do you need?
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants