Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Session] fix: session mismatch due to off-by-one block height #368

Merged
merged 6 commits into from
Feb 9, 2024

Conversation

red-0ne
Copy link
Contributor

@red-0ne red-0ne commented Feb 7, 2024

Summary

Human Summary

Fix off-by-one block height causing session mismatch errors during relaying.

AI Summary

reviewpad:summary

Issue

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Run all unit tests: make go_develop_and_test
  • Run E2E tests locally: make test_e2e
  • Run E2E tests on DevNet: Add the devnet-test-e2e label to the PR. This is VERY expensive, only do it after all the reviews are complete.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have performed a self-review of my own code
  • I have commented my code, updated documentation and left TODOs throughout the codebase

@red-0ne red-0ne added bug Something isn't working session Changes related to Session management labels Feb 7, 2024
@red-0ne red-0ne added this to the Shannon TestNet milestone Feb 7, 2024
@red-0ne red-0ne requested a review from Olshansk February 7, 2024 03:13
@red-0ne red-0ne self-assigned this Feb 7, 2024
x/session/keeper/keeper.go Show resolved Hide resolved
@red-0ne red-0ne requested a review from Olshansk February 7, 2024 15:54
e2e/tests/session.feature Show resolved Hide resolved
x/session/keeper/keeper.go Show resolved Hide resolved
x/session/keeper/keeper.go Show resolved Hide resolved
x/session/keeper/query_get_session.go Outdated Show resolved Hide resolved
x/session/keeper/query_get_session.go Show resolved Hide resolved
x/session/keeper/keeper.go Outdated Show resolved Hide resolved
x/session/keeper/keeper.go Outdated Show resolved Hide resolved
@red-0ne red-0ne requested a review from Olshansk February 9, 2024 15:19
x/session/keeper/keeper.go Show resolved Hide resolved
Copy link

github-actions bot commented Feb 9, 2024

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. If you just created a pull request, you might need to push another commit to produce a container image DevNet can utilize to spin up infrastructure. You can use make trigger_ci to push an empty commit.

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Feb 9, 2024
@red-0ne red-0ne merged commit 27c630c into main Feb 9, 2024
9 checks passed
@bryanchriswhite bryanchriswhite removed push-image CI related - pushes images to ghcr.io devnet-test-e2e labels May 16, 2024
@github-actions github-actions bot removed the devnet label May 16, 2024
okdas pushed a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working session Changes related to Session management
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants