-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: Console controller improvements and dependency updates #1893
Merged
maciaszczykm
merged 62 commits into
master
from
marcin/prod-3146-console-controller-improvements
Feb 21, 2025
Merged
enhancement: Console controller improvements and dependency updates #1893
maciaszczykm
merged 62 commits into
master
from
marcin/prod-3146-console-controller-improvements
Feb 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ler-improvements' into marcin/prod-3146-console-controller-improvements
zreigz
reviewed
Feb 12, 2025
…ler-improvements' into marcin/prod-3146-console-controller-improvements
Converting to draft to fix issues found on dev cluster. |
…nsole-controller-improvements
It should be fixed now. I will deploy it to dev cluster once image will be ready to verify if it runs correctly. |
michaeljguarino
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds
default
field toScmConnection
. It is editable even if read-only mode but any changes will be applied if it is not nil. Fixes PROD-3210.