feat: Add vector store settings #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| func (in *ElasticsearchConnectionSettings) Password(ctx context.Context, c client.Client, namespace string) (*string, error) { | ||
| if in == nil { | ||
| return nil, fmt.Errorf("configured elastic settings cannot be nil") |
There was a problem hiding this comment.
we need to make sure that error is able to be backoffed properly by the controller when the secret doesn't yet exist
There was a problem hiding this comment.
Can you review controller improvements that we did with @zreigz? It would make it easier. Otherwise I can just take some bits from that PR.
There was a problem hiding this comment.
I've integrated part of the changes from #1893. Now, not found error will be propagated to the Reconcile function and handled in handleRequeue function.
There was a problem hiding this comment.
oh my fault, yea approved that pr
michaeljguarino
approved these changes
Feb 21, 2025
michaeljguarino
deleted the
marcin/prod-3232-add-console-operator-setup-for-ai-vector-indexing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested it on dev cluster.
Example misconfigurations:
In case of not found error (i.e. password secret missing) requeue will be set to 30s.