created an accordion style dropdown for each round #104
Conversation
| <h2> {{ $round->name }} </h2> | ||
| <div class="scrollable"> | ||
| <h2 class="appTitle"> {{ $round->name }} </h2> | ||
| <div class="scrollable hidden"> |
There was a problem hiding this comment.
@Meleeman01 As per the requirements in the original issue #63, only rounds that are older than a year should have their applications hidden by default.
There was a problem hiding this comment.
aight I got that in there. I used Carbon's isLastYear() function and it seems to do it only if the date is from last year and not if the date is exactly 1 year. not sure which one you wanted but I can change it if you like.
Meleeman01
force-pushed
the
features/hideOldApplications
branch
from
4ebe801 to
f6adeb1
Compare
Meleeman01
force-pushed
the
features/hideOldApplications
branch
from
f6adeb1 to
19af682
Compare
|
|
||
| <!--check to see if the round end_date is a year old from today--> | ||
|
|
||
| @if(Carbon::parse($round->end_date)->diffInDays(Carbon::now())==365) |
There was a problem hiding this comment.
Um, wouldn't this only work if the difference in days is exactly 365?
There was a problem hiding this comment.
interestingly enough it works regardless when using diffInYears(), but i think thats something that could be made more clear as well. I tested both and they work.
No description provided.