Merge pull request #1042 from jaeheonshim-forks/inky-blocking-fix

Fix: Properly implement non-blocking update functions for the Inky Frame
pimoroni · Jan 15, 2025 · f7c45a9 · f7c45a9
2 parents d014b28 + 3811195
commit f7c45a9
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/drivers/inky73/inky73.cpp b/drivers/inky73/inky73.cpp
@@ -181,8 +181,7 @@ namespace pimoroni {
     busy_wait();
 
     command(DRF, {0}); // start display refresh
-    busy_wait();
-
+
     if(blocking) {
       busy_wait();
 

diff --git a/libraries/inky_frame/inky_frame.cpp b/libraries/inky_frame/inky_frame.cpp
@@ -66,11 +66,11 @@ namespace pimoroni {
   }
 
   void InkyFrame::update(bool blocking) {
-    while(is_busy()) {
+    while(blocking && is_busy()) {
       tight_loop_contents();
     }
     uc8159.update((PicoGraphics_PenP4 *)this);
-    while(is_busy()) {
+    while(blocking && is_busy()) {
       tight_loop_contents();
     }
     uc8159.power_off();

diff --git a/libraries/inky_frame_7/inky_frame_7.cpp b/libraries/inky_frame_7/inky_frame_7.cpp
@@ -65,11 +65,11 @@ namespace pimoroni {
   }
 
   void InkyFrame::update(bool blocking) {
-    while(is_busy()) {
+    while(blocking && is_busy()) {
       tight_loop_contents();
     }
     inky73.update((PicoGraphics_PenInky7 *)this);
-    while(is_busy()) {
+    while(blocking && is_busy()) {
       tight_loop_contents();
     }
     inky73.power_off();