Merge pull request #1049 from pimoroni/patch-pixel-span

PicoGraphics: Fix overflow bug in p4 pixel span.
pimoroni · Jan 15, 2025 · d014b28 · d014b28
2 parents a90abba + 19689b4
commit d014b28
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/libraries/pico_graphics/pico_graphics_pen_p4.cpp b/libraries/pico_graphics/pico_graphics_pen_p4.cpp
@@ -70,6 +70,10 @@ namespace pimoroni {
     }
 
     void PicoGraphics_PenP4::set_pixel_span(const Point &p, uint l) {
+        // prevent a zero length span causing an overflow in 'l'
+        // and trying to write 2GB of pixels.
+        if (l == 0) {return;}
+
         auto i = (p.x + p.y * bounds.w);
 
         // pointer to byte in framebuffer that contains this pixel