Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce log level for web requests #2244

Merged
merged 1 commit into from
Feb 22, 2025
Merged

Conversation

bennettmsherman
Copy link

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

After updating from 6.0 today, I noticed logs like the following:

2025-02-21 19:49:45.167 PST [59/T180] INFO: Local URI: "/admin/login"

This looks to have been a debug-type message added as part of: 7d8ef13

This reduces the level of such messages to DEBUG so that they will not be shown by default.

How does this PR accomplish the above?:

Log message now printed with log_debug rather than log_info. Without having dug further into the source, I followed the same approach as L35 and L44.

Link documentation PRs if any are needed to support this PR:


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@bennettmsherman
Copy link
Author

I will be honest in that I made this change via the Github UI, and was unable to build pihole locally (building the FTL package succeeded, but the dockerized build was failing to start; I suspect it's due to me disabling some components to avoid having to install mbed and nettle) to validate.

If you'd like me to figure out the build issues before merging, let me know. Given the triviality of the change I don't think it's worth the effort, but I totally understand if you'd think otherwise.

@DL6ER
Copy link
Member

DL6ER commented Feb 22, 2025

Thank you. This is indeed an oversight from debugging, I don't recall why I have not done it like that from the beginning. When you try to compile in the dedicated docker container (https://hub.docker.com/r/pihole/ftl-build), everything would be ready for you. This is also the container that would be automatically used if you'd be using VSCode and it's Dev container feature. If you want to compile FTL on "bare metal", the dependencies need to be installed but this is also not much work, see: https://docs.pi-hole.net/ftldns/compile/

@DL6ER DL6ER merged commit 8082208 into pi-hole:development Feb 22, 2025
12 checks passed
@bennettmsherman bennettmsherman deleted the patch-1 branch February 22, 2025 16:43
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/webserver-messages-in-ftl-log/76578/2

@DL6ER DL6ER mentioned this pull request Feb 26, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants