Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes the dns.domain validation to accept an empty string as value #2113

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

rdwebdesign
Copy link
Member

What does this PR aim to accomplish?

Fix the #2111 issue, where an empty string is not accepted as value for dns.domain option.

How does this PR accomplish the above?

Adding a new validation function.

Link documentation PRs if any are needed to support this PR:

none


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@rdwebdesign rdwebdesign requested a review from a team November 8, 2024 18:00
@rdwebdesign rdwebdesign linked an issue Nov 8, 2024 that may be closed by this pull request
@DL6ER DL6ER merged commit 848367f into development Nov 8, 2024
18 checks passed
@DL6ER DL6ER deleted the fix/dns_domains_validation branch November 8, 2024 18:13
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty value for dns.domain not accept from GUI
2 participants