Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty value for dns.domain not accept from GUI #2111

Closed
schuettecarsten opened this issue Nov 8, 2024 · 3 comments · Fixed by #2113
Closed

Empty value for dns.domain not accept from GUI #2111

schuettecarsten opened this issue Nov 8, 2024 · 3 comments · Fixed by #2113

Comments

@schuettecarsten
Copy link

dns.domain setting description i GUI says that I can disable the feature by setting the value to an empty string.
But empty value is not accept:

Image

Docker Tag nightly
Core vDev (development, 112b961)
FTL vDev (development, 54b4ad9)
Web interface vDev (development, c689fdc7)

@DL6ER
Copy link
Member

DL6ER commented Nov 9, 2024

This is a validation bug and should be fixed as of 848367f

@schuettecarsten
Copy link
Author

Thank you, that works now. There is another validation issue with setting dns.revServers. Description says that format is <enabled>,<ip-address>[/<prefix-len>],<server>[#<port>][,<domain>], expecting `domain to be optional:

Image

However, values without the domain parameter are not accepted:

Image

@DL6ER
Copy link
Member

DL6ER commented Nov 11, 2024

Original issue is resolved, created a new issue ticket for the ... well ... new issue.

@DL6ER DL6ER closed this as completed Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants