Make #physicalSize on BlMorphicHostSpace apply the world renderer canvas scale factor #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vas scale factor.
Closed
|
Either we create a new Pharo12 branch as we discussed few time ago, or we make some "SystemVersion current major < 12 ifTrue: [ ] ifFalse: [ ]." |
…orphicHostSpace apply the world renderer canvas scale factor”) to Pharo 12 to maintain compatibility with earlier versions.
|
I did the necessary changes using SystemVersion in commit 0dd07ef, but I did not add that commit to this pull request yet in case you prefer to have a separate ‘Pharo12’ branch (like seems to be the idea for Roassal in Roassal issue #55 and for Toplo in Toplo issue #96). |
|
Let's go with the ifs... Please, could you push the commit to the branch, to merge it into dev? |
|
I added the commit to this pull request. |
tinchodias
reviewed
Mar 14, 2024
| aClippedCanvas drawImage: spaceForm at: self position ] ] | ||
| SystemVersion current major >= 12 ifTrue: [ | ||
| | formSet | | ||
| formSet := (Smalltalk at: #FormSet) extent: self extent depth: spaceForm depth forms: { spaceForm }. |
|
You can have self class environment or Smalltalk globals at:.... |
Rinzwind
added a commit
to Rinzwind/Bloc
that referenced
this pull request
Jun 17, 2024
…ze on BlMorphicHostSpace apply the world renderer canvas scale factor”) to Pharo 12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes
#physicalSizeon BlMorphicHostSpace apply the world renderer canvas scale factor. For details see issue #450.Note that this pull request depends on changes in Pharo 12, specifically the class FormSet introduced in Pharo pull request #14998 and the method
#canvasScaleFactorfor OSWorldRenderer introduced in Pharo pull request #15647.