Add Toplo world menu entry

[tinchodias]

No description provided.

[request-info]

This issue has either a default title or empty body. We would appreciate it if you could provide more information. Note: I am not a very intelligent bot, I can only react to new comments. Please add a comment for me if you update the body or title.

[tesonep]

Fix #16289

[tinchodias]

I just downloaded P12 via zeroconf and don't see the menu entry. After 6 hours. I have to wait more or it was reverted?

Build information: Pharo-12.0.0+SNAPSHOT.build.1474.sha.723e992378842828924aea037a6d2da975cd8da4 (64 Bit)

[Rinzwind]

It wasn’t reverted, but in the build that was triggered for the commit in which this pull request was merged (build 1475), the ‘Full Image-64’ stage failed due to issue #16443, and while the issue seems to have been fixed, there hasn’t been another build yet.

[Rinzwind]

It would have been nice if the change to Spec that seems to fix issue #16443 would have triggered a new build so that there would be an image with the changes of this pull request, I have opened an issue about that: issue #16452.

[Rinzwind]

@tinchodias: There are images for newer builds now. There’s no Toplo world menu item as far as I can tell though. The class BlLoadProjectWorldMenu seems to be missing methods with a <worldMenu> pragma.

[tinchodias]

@Rinzwind many thanks! Silly me, I forgot to include a method in the PR changes. Luckily I located the image where I worked that day and was able to push the missing method addition (PR #16478)

[Rinzwind]

Ah OK! I wasn’t quite sure whether the <worldMenu> pragma method was missing or whether the menu item was supposed to get added in some other way that I was not seeing.

I wanted to take a look because I was wondering whether the menu item would load a version including the world renderer canvas scale factor support and the Toplo demo browser which I added in Bloc pull request #465 and Toplo pull request #120.

[tinchodias]

@Rinzwind This menu entry loads the Pharo12 branch of Toplo, and we will take care it loads a reasonably good version of Toplo and Bloc, and should have a stable version that works well in Pharo 12 release and can update from time to time to a more recent version.