Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asset: add coingecko_id to Metadata struct #5007

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

vacekj
Copy link
Member

@vacekj vacekj commented Jan 27, 2025

Extends the Inner struct in denom_metadata.rs to include a coingecko_id field. Updates related methods to handle the new field, including From, TryFrom, Debug, and default initialization.

Issue ticket number and link

prax-wallet/registry#121

Checklist before requesting a review

  • I have added guiding text to explain how a reviewer should test these changes.

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

Extends the `Inner` struct in `denom_metadata.rs` to include a `coingecko_id` field. Updates related methods to handle the new field, including `From`, `TryFrom`, `Debug`, and default initialization.
@erwanor
Copy link
Member

erwanor commented Jan 27, 2025

Thanks!

@erwanor erwanor merged commit 8463d63 into main Jan 27, 2025
15 checks passed
@erwanor erwanor deleted the feat/add-coingecko-id-to-metadata branch January 27, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants