proto: transaction format cleanup #3542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdevalence
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
This commit: - Aligns the `TransactionPlan` with the `Transaction` data structure - Moves the `fee` into the `TransactionParameters` Now the transaction body consists solely of: - a list of `Action`s describing changes to the chain state - a set of `TransactionParameters` describing under what conditions those changes can be applied - a set of `DetectionData` (extensible) for assisting with transaction detection - a set of `MemoData` with encrypted information about the transaction's purpose.
hdevalence
force-pushed
the
tx-proto-fixes
branch
from
a3f76dc to
fa4fdbf
Compare
hdevalence
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
|
|
hdevalence
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
hdevalence
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
This commit makes detection data handling consistent with memo handling, using an optional field to record the presence or absence of detection data. Also, it fixes the effect hash computation to always hash something for the memo and for the detection data, ensuring that absent packets are correctly recorded in the effect hash.
hdevalence
had a problem deploying
to
smoke-test
GitHub Actions
Error
hdevalence
commented
Dec 29, 2023
Comment on lines
+75
to
+77
| state.update(parameters_hash.as_bytes()); | ||
| state.update(memo_hash.as_bytes()); | ||
| state.update(detection_data_hash.as_bytes()); |
There was a problem hiding this comment.
cc @redshiftzero ; in the case of a ledger or similar device, we can avoid having the ledger compute FMD clues by passing the detection data hash from the host device to the ledger
hdevalence
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit:
TransactionPlanwith theTransactiondata structurefeeinto theTransactionParametersNow the transaction body consists solely of:
Actions describing changes to the chain stateTransactionParametersdescribing under what conditions those changes can be appliedDetectionData(extensible) for assisting with transaction detectionMemoDatawith encrypted information about the transaction's purpose.