Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak proto definitions for fees #3391

Closed
1 of 2 tasks
Tracked by #3367
hdevalence opened this issue Nov 16, 2023 · 2 comments
Closed
1 of 2 tasks
Tracked by #3367

Tweak proto definitions for fees #3391

hdevalence opened this issue Nov 16, 2023 · 2 comments
Assignees
@aubrika
Labels
_P-V1 Priority: slated for V1 release

Comments

@hdevalence
Copy link
Member

hdevalence commented Nov 16, 2023 •
edited
Loading

We should consider:

  • moving the fee into the TransactionParameters
  • adding a FeeView to provide denom support.
@hdevalence hdevalence mentioned this issue Nov 16, 2023
Open
14 tasks
@aubrika aubrika added the _P-V1 Priority: slated for V1 release label Nov 16, 2023
@aubrika aubrika added this to Penumbra Nov 16, 2023
@aubrika aubrika removed this from Testnets Nov 16, 2023
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra Nov 16, 2023
@aubrika aubrika moved this from 🗄️ Backlog to 📝 Todo in Penumbra Nov 16, 2023
@aubrika aubrika self-assigned this Dec 6, 2023
@aubrika aubrika moved this from 📝 Todo to 🏗 In progress in Penumbra Dec 6, 2023
@aubrika aubrika mentioned this issue Dec 6, 2023
Closed
This was referenced Dec 26, 2023
Closed
Merged
@aubrika
Copy link
Contributor

aubrika commented Jan 4, 2024

Slipped due to unclear scope - adding the FeeView is no problem but moving the fee into the TransactionParameters was more of a refactor than expected & added bug surface - do we want to revisit/reprioritize this for the next release?

@hdevalence
Copy link
Member Author

The first point was done in #3542, but there's no FeeView. I'm not sure if we should add it, we would have to make a TransactionParametersView and it doesn't do much because we only accept one asset type as the fee token.

@hdevalence hdevalence closed this as not planned Won't fix, can't repro, duplicate, stale Jan 4, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Penumbra Jan 4, 2024
@github-project-automation github-project-automation bot moved this to Testnet 63: Rhea (Web Wallet) in Testnets Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aubrika aubrika

Labels
_P-V1 Priority: slated for V1 release
Projects
Penumbra
Archived in project
Testnets
Status: Testnet 63: Rhea (Web Wallet)
Milestone
No milestone
2 participants
@hdevalence @aubrika