Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeOwners component #498

Merged
merged 1 commit into from
Jan 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/apollo-server/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,21 @@ import {TypeScriptAppProject, TypeScriptProjectOptions} from 'projen/lib/typescr
import {WithDocker} from '../common'
import {AssetFile} from '../common/files/AssetFile'
import {WithGitHooks, addHusky, extendGitignore} from '../common/git'
import {ProjenDriftCheckWorkflow, PullRequestTest, WithDefaultWorkflow} from '../common/github'
import {
CodeOwners,
ProjenDriftCheckWorkflow,
PullRequestTest,
WithCodeOwners,
WithDefaultWorkflow,
} from '../common/github'
import {WithCustomLintPaths, addLinters} from '../common/lint'
import {IWithTelemetryReportUrl, WithTelemetry, collectTelemetry, setupTelemetry} from '../common/telemetry'
import {addVsCode} from '../common/vscode-settings'
import {sampleCode} from './sample-code'

export interface OttofellerApolloServerProjectOptions
extends TypeScriptProjectOptions,
WithCodeOwners,
WithDocker,
WithDefaultWorkflow,
WithCustomLintPaths,
Expand Down Expand Up @@ -155,9 +162,10 @@ export class OttofellerApolloServerProject extends TypeScriptAppProject implemen
const lintPaths = options.lintPaths ?? ['src']
addLinters({project: this, lintPaths})

// ANCHOR Github workflow
// ANCHOR Github
PullRequestTest.addToProject(this, {...options, isLighthouseEnabled: false})
ProjenDriftCheckWorkflow.addToProject(this, options)
CodeOwners.addToProject(this, options)

// ANCHOR Codegen
new AssetFile(this, 'codegen.ts', {sourcePath: path.join(assetsDir, 'codegen.ts'), readonly: false, marker: false})
Expand Down
4 changes: 4 additions & 0 deletions src/cdk/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@ import {NodePackageManager} from 'projen/lib/javascript'
import {AssetFile} from '../common'
import {WithGitHooks, addHusky, extendGitignore} from '../common/git'
import {
CodeOwners,
ProjenDriftCheckWorkflow,
PullRequestTest,
ReleaseWorkflow,
RustTestWorkflow,
WithCodeOwners,
WithDefaultWorkflow,
WithRustTestWorkflow,
} from '../common/github'
Expand All @@ -19,6 +21,7 @@ import {addVsCode} from '../common/vscode-settings'

export interface OttofellerCDKProjectOptions
extends AwsCdkTypeScriptAppOptions,
WithCodeOwners,
WithDefaultWorkflow,
WithRustTestWorkflow,
WithCustomLintPaths,
Expand Down Expand Up @@ -139,6 +142,7 @@ export class OttofellerCDKProject extends AwsCdkTypeScriptApp implements IWithTe
}

RustTestWorkflow.addToProject(this, options)
CodeOwners.addToProject(this, options)

// ANCHOR Set up GraphQL
const isGraphqlCodegenEnabled = options.isGraphqlCodegenEnabled ?? false
Expand Down
Loading
Loading