Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeOwners component #498

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Add CodeOwners component #498

merged 1 commit into from
Jan 11, 2024

Conversation

quesabe
Copy link
Collaborator

@quesabe quesabe commented Jan 6, 2024

Closes PLA-290.

The component is a simple extension to FileBase that collects a list of patterns and renders them in a simple text format.

It is a component related to GitHub, so I restricted its creation to projects that have github component. Moreover it does not look at the parent and thus in a monorepo it is assumed only the root project would define code owners. This decision is up for discussion.

@quesabe quesabe requested a review from gvidon January 6, 2024 09:12
@quesabe quesabe self-assigned this Jan 6, 2024
Copy link

linear bot commented Jan 6, 2024

PLA-290

@quesabe quesabe force-pushed the codeowners branch 2 times, most recently from 03f11bc to 99b3837 Compare January 6, 2024 09:19
src/nextjs/index.ts Outdated Show resolved Hide resolved
src/apollo-server/index.ts Outdated Show resolved Hide resolved
@quesabe quesabe requested a review from gvidon January 7, 2024 15:00
@gvidon
Copy link
Contributor

gvidon commented Jan 9, 2024

@quesabe please fix the conflicts and feel free merging yourself.

@quesabe quesabe merged commit 97f950b into main Jan 11, 2024
7 checks passed
@quesabe quesabe deleted the codeowners branch January 11, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants