Build images with cockpit (HMS-5417) #2787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
croissanne
force-pushed
the
blueprints-and-composes-cockpit
branch
2 times, most recently
from
253559b to
d2479f6
Compare
croissanne
force-pushed
the
blueprints-and-composes-cockpit
branch
2 times, most recently
from
df3f978 to
979eb42
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #2787 +/- ##
==========================================
- Coverage 84.55% 83.22% -1.33%
==========================================
Files 190 190
Lines 21811 22214 +403
Branches 2169 2174 +5
==========================================
+ Hits 18442 18488 +46
- Misses 3347 3704 +357
Partials 22 22
Continue to review full report in Codecov by Sentry.
|
croissanne
force-pushed
the
blueprints-and-composes-cockpit
branch
from
979eb42 to
e417e88
Compare
croissanne
force-pushed
the
blueprints-and-composes-cockpit
branch
from
e417e88 to
929c498
Compare
croissanne
force-pushed
the
blueprints-and-composes-cockpit
branch
from
929c498 to
01f12b6
Compare
croissanne
force-pushed
the
blueprints-and-composes-cockpit
branch
2 times, most recently
from
d605846 to
32be84b
Compare
kingsleyzissou
approved these changes
Jan 29, 2025
|
/jira-epic COMPOSER-2411 |
schutzbot
changed the title
`.cache` is for writing, `.local/share` is technically static data.
The structure of the local cache is now:
```
└── blueprint
└── blueprint.json
└── image1
└── image2
└── blueprint2
└── blueprint2.json
└── image1
```
Building an image reads the blueprint, and creates a new image file
under the relevant blueprint folder, which contains the image request.
The image request that's sent off to composer and the request that's
saved differs slightly in the upload structures.
The mixed api supports both the service and on-prem.
Reads all of the image entries under the cache.
Finds the relevant compose, asks for its status and reads the original compose request from disk.
Adds `mtime` tot fsinfo, and `replace` to `cockpit.file`.
With the custom query functions the cached data from getComposes and getBlueprintComposes doesn't get invalidated. Luckily RTKQuery provides a mechanism to invalidate the cache after a mutation.
croissanne
force-pushed
the
blueprints-and-composes-cockpit
branch
from
32be84b to
df0fbcc
Compare
kingsleyzissou
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cockpit-ib.mp4
JIRA: HMS-5417