[WIP] cockpit create blueprint #2780
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The browser router doesn't seem to work inside cockpit, switching to the hashrouter resolves this.
Switch the useFlag usage to the stub function defined in the `useGetEnvironment` utility
We need to check for the on-prem use case
We were making a call to a dead endpoint to get the architectures. Instead, create a custom query function to return the list of architectures and image types.
Create a get blueprint endpoint for the on-prem store.
Create the boilerplate function for getting the Oscap profiles. We will need to make a call to the `oscap` binary to get this information. So we will leave it empty for now.
Create a helper hook for RTK prefetch queries. This wrapper function is needed since the imagebuilderApi and cockpitApi aren't at parity yet.
Currently, the wizard still needs some of the other stores. If we omit them, the wizard fails to launch
Including an image in the on prem version inside cockpit is not trivial. We need a bit of a workaround to get the various target icons showing on the on-prem version in cockpit.
For a start, we will disable custom repositories and the OpenSCAP steps for the on-prem version of the frontend.
Subject says it all
kingsleyzissou
force-pushed
the
cockpit_create
branch
from
5e15855 to
78d918f
Compare
Add a hook that gets the host distro for the on-prem frontend. If there is an issue we will fallback to the default. For the service we also just use the default distro.
Add a stub function for the `os-release` package from cockpit.
We can ignore the org-id when trying to get the state of the blueprint during the blueprint creation. This is unnecessary info for `on-prem`
This is not ideal, but we needed to add an empty endpoint for this, even though we're ignoring it on prem. The frontend for the service makes the api call regardless, so we can't ignore this.
kingsleyzissou
force-pushed
the
cockpit_create
branch
from
78d918f to
bc12708
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a work in progress for creating a blueprint from the CreateImageWizard.