Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard: Add firewall services (HMS-5353) #2767

Merged
merged 1 commit into from
Jan 29, 2025

Wizard: Add firewall services

812a3c3
Select commit
Loading
Failed to load commit list.
Merged

Wizard: Add firewall services (HMS-5353) #2767

Wizard: Add firewall services
812a3c3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 29, 2025 in 0s

84.55% (+0.00%) compared to 3c27f68

View this Pull Request on Codecov

84.55% (+0.00%) compared to 3c27f68

Details

Codecov Report

Attention: Patch coverage is 87.03704% with 14 lines in your changes missing coverage. Please review.

Project coverage is 84.55%. Comparing base (3c27f68) to head (812a3c3).

Files with missing lines Patch % Lines
src/store/wizardSlice.ts 68.18% 14 Missing ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2767   +/-   ##
=======================================
  Coverage   84.54%   84.55%           
=======================================
  Files         189      190    +1     
  Lines       21713    21811   +98     
  Branches     2159     2169   +10     
=======================================
+ Hits        18358    18442   +84     
- Misses       3333     3347   +14     
  Partials       22       22           
Files with missing lines Coverage Δ
...ageWizard/steps/Firewall/components/PortsInput.tsx 100.00% <100.00%> (ø)
...ImageWizard/steps/Firewall/components/Services.tsx 100.00% <100.00%> (ø)
...ponents/CreateImageWizard/steps/Firewall/index.tsx 100.00% <100.00%> (ø)
...nents/CreateImageWizard/utilities/requestMapper.ts 94.89% <100.00%> (+0.09%) ⬆️
src/Components/CreateImageWizard/validators.ts 93.80% <100.00%> (+0.40%) ⬆️
src/store/wizardSlice.ts 87.85% <68.18%> (-1.16%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c27f68...812a3c3. Read the comment docs.