Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard: Add firewall services (HMS-5353) #2767

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

regexowl
Copy link
Collaborator

@regexowl regexowl commented Jan 20, 2025

This adds firewall services, using the <ChippingInput> components. New tests were also added.

JIRA: HMS-5353

@regexowl
Copy link
Collaborator Author

/jira-epic HMS-5168

@schutzbot schutzbot changed the title Wizard: Add firewall services Wizard: Add firewall services (HMS-5353) Jan 20, 2025
@regexowl regexowl marked this pull request as draft January 20, 2025 08:48
@regexowl regexowl marked this pull request as ready for review January 20, 2025 09:22
This adds firewall services, using the `<ChippingInput>` components. New tests were also added.
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 86.91589% with 14 lines in your changes missing coverage. Please review.

Project coverage is 84.74%. Comparing base (c6bee55) to head (57fccbe).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/store/wizardSlice.ts 68.18% 14 Missing ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2767   +/-   ##
=======================================
  Coverage   84.73%   84.74%           
=======================================
  Files         186      187    +1     
  Lines       21248    21345   +97     
  Branches     2087     2097   +10     
=======================================
+ Hits        18005    18088   +83     
- Misses       3221     3235   +14     
  Partials       22       22           
Files with missing lines Coverage Δ
...ageWizard/steps/Firewall/components/PortsInput.tsx 100.00% <100.00%> (ø)
...ImageWizard/steps/Firewall/components/Services.tsx 100.00% <100.00%> (ø)
...ponents/CreateImageWizard/steps/Firewall/index.tsx 100.00% <100.00%> (ø)
...nents/CreateImageWizard/utilities/requestMapper.ts 94.81% <100.00%> (+0.09%) ⬆️
src/Components/CreateImageWizard/validators.ts 94.94% <100.00%> (+0.32%) ⬆️
src/store/wizardSlice.ts 87.61% <68.18%> (-1.18%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6bee55...57fccbe. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant