Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard: Add firewall to Review step (HMS-5357) #2769

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

regexowl
Copy link
Collaborator

@regexowl regexowl commented Jan 20, 2025

This adds a firewall expandable to the Review step.

JIRA: HMS-5357

@regexowl
Copy link
Collaborator Author

regexowl commented Jan 20, 2025

Rebased on #2767, so that will need to get merged first.

@regexowl
Copy link
Collaborator Author

/jira-epic HMS-5168

@schutzbot schutzbot changed the title Wizard: Add firewall to Review step Wizard: Add firewall to Review step (HMS-5357) Jan 20, 2025
@regexowl regexowl force-pushed the firewall-on-review-step branch from dc393b3 to cf33a94 Compare January 21, 2025 12:43
This adds firewall services, using the `<ChippingInput>` components. New tests were also added.
This adds a firewall expandable to the Review step.
@regexowl regexowl force-pushed the firewall-on-review-step branch from cf33a94 to ee797cb Compare January 23, 2025 08:21
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 91.51515% with 14 lines in your changes missing coverage. Please review.

Project coverage is 84.78%. Comparing base (c6bee55) to head (ee797cb).

Files with missing lines Patch % Lines
src/store/wizardSlice.ts 68.18% 14 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2769      +/-   ##
==========================================
+ Coverage   84.73%   84.78%   +0.04%     
==========================================
  Files         186      187       +1     
  Lines       21248    21403     +155     
  Branches     2087     2109      +22     
==========================================
+ Hits        18005    18146     +141     
- Misses       3221     3235      +14     
  Partials       22       22              
Files with missing lines Coverage Δ
...ageWizard/steps/Firewall/components/PortsInput.tsx 100.00% <100.00%> (ø)
...ImageWizard/steps/Firewall/components/Services.tsx 100.00% <100.00%> (ø)
...ponents/CreateImageWizard/steps/Firewall/index.tsx 100.00% <100.00%> (ø)
...ents/CreateImageWizard/steps/Review/ReviewStep.tsx 94.94% <100.00%> (+0.33%) ⬆️
...teImageWizard/steps/Review/ReviewStepTextLists.tsx 95.00% <100.00%> (+0.27%) ⬆️
...nents/CreateImageWizard/utilities/requestMapper.ts 94.81% <100.00%> (+0.09%) ⬆️
src/Components/CreateImageWizard/validators.ts 94.94% <100.00%> (+0.32%) ⬆️
src/store/wizardSlice.ts 87.61% <68.18%> (-1.18%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6bee55...ee797cb. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant