on-prem: cockpit create image wizard (HMS-5301) #2735

kingsleyzissou · 2025-01-10T13:15:45Z

This PR adds some changes for us to open the create image wizard for on-prem:

switch to hash router
implement a few more store methods
add some more plumbing

/jira-epic COMPOSER-2411

JIRA: HMS-5301

codecov · 2025-01-10T13:29:46Z

Codecov Report

Attention: Patch coverage is 51.01010% with 97 lines in your changes missing coverage. Please review.

Project coverage is 84.51%. Comparing base (6a29f7f) to head (12606ed).
Report is 15 commits behind head on main.

Files with missing lines	Patch %	Lines
src/store/cockpitApi.ts	19.35%	50 Missing ⚠️
...Components/CreateImageWizard/CreateImageWizard.tsx	38.88%	11 Missing ⚠️
...ponents/CreateImageWizard/utilities/getHostInfo.ts	27.27%	8 Missing ⚠️
src/store/backendApi.ts	65.00%	7 Missing ⚠️
src/test/mocks/os-release/index.ts	12.50%	7 Missing ⚠️
src/AppCockpit.tsx	0.00%	3 Missing ⚠️
src/Utilities/useGetEnvironment.ts	66.66%	3 Missing ⚠️
...CreateImageWizard/steps/ImageOutput/ArchSelect.tsx	75.00%	2 Missing ⚠️
...ateImageWizard/steps/ImageOutput/ReleaseSelect.tsx	85.71%	2 Missing ⚠️
src/Utilities/path.ts	33.33%	2 Missing ⚠️
... and 2 more

@@            Coverage Diff             @@
##             main    #2735      +/-   ##
==========================================
- Coverage   84.81%   84.51%   -0.31%     
==========================================
  Files         187      189       +2     
  Lines       21388    21530     +142     
  Branches     2120     2137      +17     
==========================================
+ Hits        18141    18196      +55     
- Misses       3225     3312      +87     
  Partials       22       22

Files with missing lines	Coverage Δ
src/Components/Blueprints/BlueprintDiffModal.tsx	`88.46% <100.00%> (ø)`
src/Components/Blueprints/BuildImagesButton.tsx	`71.64% <ø> (ø)`
...c/Components/CreateImageWizard/EditImageWizard.tsx	`100.00% <100.00%> (ø)`
...mageWizard/steps/ImageOutput/TargetEnvironment.tsx	`91.98% <100.00%> (ø)`
...Components/CreateImageWizard/steps/Oscap/Oscap.tsx	`92.80% <ø> (ø)`
...Components/CreateImageWizard/steps/Oscap/index.tsx	`98.21% <100.00%> (-0.07%)`	⬇️
...ents/CreateImageWizard/steps/Packages/Packages.tsx	`79.63% <ø> (ø)`
...ponents/CreateImageWizard/steps/Packages/index.tsx	`100.00% <100.00%> (ø)`
...nts/CreateImageWizard/steps/Registration/index.tsx	`100.00% <100.00%> (ø)`
...teImageWizard/steps/Review/ReviewStepTextLists.tsx	`94.73% <100.00%> (+<0.01%)`	⬆️
... and 17 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a29f7f...12606ed. Read the comment docs.

kingsleyzissou · 2025-01-10T16:27:22Z

This depends on #2704

kingsleyzissou · 2025-01-13T09:40:59Z

Marking as draft as this also depends on #2739

kingsleyzissou · 2025-01-23T16:10:43Z

Screen.Recording.2025-01-23.at.16.08.09.mov

This doesn't include:

package selection
~~still need to limit the arch dropdown~~
creating the blueprint

croissanne

LGTM, some small comments, but I'd leave out the logos/icons for now, I'm not sure if we can just do that :/

src/Components/CreateImageWizard/steps/ImageOutput/TargetEnvironment.tsx

src/store/cockpitApi.ts

The browser router doesn't seem to work inside cockpit, switching to the hashrouter resolves this.

Switch the useFlag usage to the stub function defined in the `useGetEnvironment` utility

We need to check for the on-prem use case

croissanne · 2025-01-27T15:06:01Z

/retest

regexowl · 2025-01-27T15:13:07Z

Just a heads up - failure of the two bonfire konflux actions is expected and should be safe to ignore.

croissanne

lgtm, some repos are still there though

src/store/cockpitApi.ts

kingsleyzissou · 2025-01-27T15:18:27Z

lgtm, some repos are still there though

smh. Sorry. Just going to fix that up quickly

We were making a call to a dead endpoint to get the architectures. Instead, create a custom query function to return the list of architectures and image types.

Create a get blueprint endpoint for the on-prem store.

Create the boilerplate function for getting the Oscap profiles. We will need to make a call to the `oscap` binary to get this information. So we will leave it empty for now.

Create a helper hook for RTK prefetch queries. This wrapper function is needed since the imagebuilderApi and cockpitApi aren't at parity yet.

Currently, the wizard still needs some of the other stores. If we omit them, the wizard fails to launch

For a start, we will disable custom repositories and the OpenSCAP steps for the on-prem version of the frontend.

Subject says it all

Add a stub function for the `os-release` package from cockpit.

Initialize the create image wizard with the host's distribution for the on-premise frontend.

Initialize the create image wizard with the host arch for the on-prem frontend.

The list of imports was growing really long and getting a bit unmanageable. This commit tidies the imports up by importing all the queries into two variables.

schutzbot changed the title ~~on-prem: cockpit create image wizard~~ on-prem: cockpit create image wizard (HMS-5301) Jan 10, 2025

schutzbot added the 🌟 best practice label Jan 10, 2025

kingsleyzissou force-pushed the cockpit_wizard branch from d2a1b9f to aea2b03 Compare January 10, 2025 13:21

kingsleyzissou marked this pull request as ready for review January 10, 2025 16:27

kingsleyzissou force-pushed the cockpit_wizard branch 2 times, most recently from d5adf33 to 1c6e08c Compare January 13, 2025 09:39

kingsleyzissou marked this pull request as draft January 13, 2025 09:40

kingsleyzissou force-pushed the cockpit_wizard branch 3 times, most recently from afa0ced to ba3bf8a Compare January 20, 2025 12:13

kingsleyzissou marked this pull request as ready for review January 20, 2025 12:14

kingsleyzissou force-pushed the cockpit_wizard branch 5 times, most recently from cb3d3e8 to 9b58183 Compare January 23, 2025 15:17

kingsleyzissou requested review from lucasgarfield and croissanne January 23, 2025 15:55

kingsleyzissou force-pushed the cockpit_wizard branch from 9b58183 to 76a353c Compare January 23, 2025 15:56

kingsleyzissou force-pushed the cockpit_wizard branch from 76a353c to bc016ae Compare January 23, 2025 16:11

croissanne requested changes Jan 27, 2025

View reviewed changes

src/Components/CreateImageWizard/steps/ImageOutput/TargetEnvironment.tsx Outdated Show resolved Hide resolved

src/store/cockpitApi.ts Outdated Show resolved Hide resolved

src/store/cockpitApi.ts Show resolved Hide resolved

kingsleyzissou added 3 commits January 27, 2025 14:30

cockpit: switch to hashrouter

de2f054

The browser router doesn't seem to work inside cockpit, switching to the hashrouter resolves this.

multi: on-prem can't use the unleash flag

8fc793c

Switch the useFlag usage to the stub function defined in the `useGetEnvironment` utility

Utilities: fix useGetEnvironment

a856e21

We need to check for the on-prem use case

kingsleyzissou force-pushed the cockpit_wizard branch 2 times, most recently from 7b39b18 to 5135443 Compare January 27, 2025 14:40

croissanne previously approved these changes Jan 27, 2025

View reviewed changes

src/store/cockpitApi.ts Outdated Show resolved Hide resolved

kingsleyzissou and others added 12 commits January 27, 2025 15:19

store/cockpitApi: getArchitectures endpoint

240e658

We were making a call to a dead endpoint to get the architectures. Instead, create a custom query function to return the list of architectures and image types.

store/cockpitApi: get blueprint endpoint

478bbb3

Create a get blueprint endpoint for the on-prem store.

store/cockpitApi: empty get oscap profiles function

b7293ab

Create the boilerplate function for getting the Oscap profiles. We will need to make a call to the `oscap` binary to get this information. So we will leave it empty for now.

store/backendApi: create a useBackendPrefetch hook

230f543

Create a helper hook for RTK prefetch queries. This wrapper function is needed since the imagebuilderApi and cockpitApi aren't at parity yet.

store: add missing apis to onPrem

3326233

Currently, the wizard still needs some of the other stores. If we omit them, the wizard fails to launch

CreateImageWizard: disable steps for on-prem

fbe9f4c

For a start, we will disable custom repositories and the OpenSCAP steps for the on-prem version of the frontend.

CreateImageWizard: hide activation keys for on-prem

3b82e72

Subject says it all

constants: add centos-10 & fedora-41

e36d696

test/mocks: add cockpit os-release

2afb5b1

Add a stub function for the `os-release` package from cockpit.

CreateImageWizard: initialize on-prem with host distro

57a8480

Initialize the create image wizard with the host's distribution for the on-premise frontend.

CreateImageWizard: initialize on-prem with host arch

f7a6f02

Initialize the create image wizard with the host arch for the on-prem frontend.

store/backendApi: tidy up mixed api imports

12606ed

The list of imports was growing really long and getting a bit unmanageable. This commit tidies the imports up by importing all the queries into two variables.

kingsleyzissou dismissed croissanne’s stale review via 12606ed January 27, 2025 15:19

kingsleyzissou force-pushed the cockpit_wizard branch from 5135443 to 12606ed Compare January 27, 2025 15:19

croissanne approved these changes Jan 27, 2025

View reviewed changes

croissanne enabled auto-merge (rebase) January 27, 2025 15:32

croissanne merged commit f2c5dcc into osbuild:main Jan 27, 2025
17 of 19 checks passed

kingsleyzissou mentioned this pull request Jan 28, 2025

cockpit: make CreateImageWizard functional (HMS-5408) #2780

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

on-prem: cockpit create image wizard (HMS-5301) #2735

on-prem: cockpit create image wizard (HMS-5301) #2735

kingsleyzissou commented Jan 10, 2025 •

edited by schutzbot

Loading

codecov bot commented Jan 10, 2025 •

edited

Loading

kingsleyzissou commented Jan 10, 2025

kingsleyzissou commented Jan 13, 2025

kingsleyzissou commented Jan 23, 2025 •

edited

Loading

croissanne left a comment •

edited

Loading

croissanne commented Jan 27, 2025

regexowl commented Jan 27, 2025

croissanne left a comment

kingsleyzissou commented Jan 27, 2025

on-prem: cockpit create image wizard (HMS-5301) #2735

on-prem: cockpit create image wizard (HMS-5301) #2735

Conversation

kingsleyzissou commented Jan 10, 2025 • edited by schutzbot Loading

codecov bot commented Jan 10, 2025 • edited Loading

Codecov Report

kingsleyzissou commented Jan 10, 2025

kingsleyzissou commented Jan 13, 2025

kingsleyzissou commented Jan 23, 2025 • edited Loading

croissanne left a comment • edited Loading

Choose a reason for hiding this comment

croissanne commented Jan 27, 2025

regexowl commented Jan 27, 2025

croissanne left a comment

Choose a reason for hiding this comment

kingsleyzissou commented Jan 27, 2025

kingsleyzissou commented Jan 10, 2025 •

edited by schutzbot

Loading

codecov bot commented Jan 10, 2025 •

edited

Loading

kingsleyzissou commented Jan 23, 2025 •

edited

Loading

croissanne left a comment •

edited

Loading