vendor: remove the vendored dependencies #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we add the |
mvo5
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
croissanne
force-pushed
the
drop-vendoring
branch
from
9cbeed1 to
e05fe2d
Compare
|
Everything is green, I set this to "ready", what could possibly go wrong? (but in all seriousness, this needs a careful review but I don't see why we need the vendor/ dir anymore in |
|
All tests had passed but the branch is out of date. :-( |
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 30+7 days with no activity. |
|
Fixed conflicts and reopened. |
lzap
previously approved these changes
Jan 6, 2025
|
There's a conflict again because of #1451, otherwise lgtm! |
|
Oh no I am so sorry! |
Similar to what we did in `images` in PR#861 (thanks to @achilleas-k) this commit removes the vendoring from image-builder. We don't package image-builder so just like with images we don't need the vendor dir (go.{mod,sum} is fine to re-create the environment).
This command no longer needs to run.
lzap
approved these changes
Jan 8, 2025
achilleas-k
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to what we did in
imagesin PR#861 (thanks to @achilleas-k)this commit removes the vendoring from image-builder. We don't
package image-builder so just like with images we don't need the
vendor dir (go.{mod,sum} is fine to re-create the environment).
C.f. osbuild/images#1041 and #1402 (comment)