Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: Support both DateOnly and RFC3339 format for snapshot dates #1452

Merged
merged 1 commit into from
Jan 8, 2025
Merged

internal: Support both DateOnly and RFC3339 format for snapshot dates #1452

merged 1 commit into from
Jan 8, 2025

Conversation

regexowl
Copy link
Contributor

@regexowl regexowl commented Jan 7, 2025

This adds back support for DateOnly format of snapshot dates.

@regexowl regexowl force-pushed the allow-rfc-and-dateonly branch from 1704311 to 16bc27c Compare January 7, 2025 16:21
@regexowl regexowl marked this pull request as ready for review January 8, 2025 07:40
@regexowl
Copy link
Contributor Author

regexowl commented Jan 8, 2025

We'll need to support both DateOnly and RFC3339 date format at least temporarily to not break older blueprints. Hope this is not too ugly. Tried to add a test case as well.

@regexowl regexowl requested a review from croissanne January 8, 2025 07:41
lzap
lzap approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@lzap lzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please do not merge before #1418 we want to get rid of the vendor directory, yay! We will ask you to rebase on top of that change, easy merge just delete vendor/ alltogether.

@regexowl
internal: Support both DateOnly and RFC3339 format for snapshot dates
2600a6d 
This adds back support for DateOnly format of snapshot dates.
@regexowl regexowl force-pushed the allow-rfc-and-dateonly branch from 16bc27c to 2600a6d Compare January 8, 2025 13:43
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/v1/handler_compose_image.go 80.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
internal/v1/handler_compose_image.go 64.89% <80.00%> (+0.15%) ⬆️

@regexowl regexowl merged commit 2e9692e into osbuild:main Jan 8, 2025
17 checks passed
@regexowl regexowl deleted the allow-rfc-and-dateonly branch January 8, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzap lzap lzap approved these changes

@croissanne croissanne Awaiting requested review from croissanne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@regexowl @lzap