Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix($output-style): Removes accidental trailing curly-brace #45

Merged
merged 2 commits into from
Dec 21, 2021

Conversation

fbartho
Copy link
Contributor

@fbartho fbartho commented Dec 21, 2021

Output had a curly brace that was either auto-completed, or fumble-fingered by myself, and I didn't
catch it in the PR where it was introduced. (from #44)

orta and others added 2 commits December 20, 2021 11:42
Output had a curly brace that was either auto-completed, or fumble-fingered by myself, and I didn't
catch it in the PR where it was introduced.
@orta
Copy link
Owner

orta commented Dec 21, 2021

Ace, thanks !

@orta orta merged commit 6f9eeab into orta:main Dec 21, 2021
@orta
Copy link
Owner

orta commented Dec 21, 2021

Shipped as 1.4.1

@fbartho fbartho deleted the fb/typo-fix branch December 21, 2021 20:45
@fbartho fbartho mentioned this pull request Jan 11, 2022
@glensc
Copy link
Contributor

glensc commented Mar 21, 2022

  1. this is still present in 1.4.1: Weird } in gitlab output #48
  2. git tags not present: All git tags missing #49, difficult to check what should be in a release

This was referenced Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants