Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird } in gitlab output #48

Closed
glensc opened this issue Mar 21, 2022 · 9 comments
Closed

Weird } in gitlab output #48

glensc opened this issue Mar 21, 2022 · 9 comments

Comments

@glensc
Copy link
Contributor

glensc commented Mar 21, 2022

image

Seems to be present after each package name.

Here's copy of full HTML:

@glensc
Copy link
Contributor Author

glensc commented Mar 22, 2022

@orta can you make a new release, this time actually containing the fix?

See #45 (comment)

Preferably with some automation for transparency to the end users:

@glensc
Copy link
Contributor Author

glensc commented Mar 22, 2022

The current workaround, use any version before:

That appears to be 1.3.3

@glensc
Copy link
Contributor Author

glensc commented Mar 28, 2022

@orta ping. seems easy fix just make new release from the default branch

@orta
Copy link
Owner

orta commented Mar 29, 2022

Yep, deployed as 1.5.0

@glensc
Copy link
Contributor Author

glensc commented Mar 29, 2022

Looks like 1.5.0 update is breaking change. No longer can run jest


    Details:

    /Users/glen/Library/Caches/glen/node_modules/danger-plugin-dangered/node_modules/danger-plugin-yarn/node_modules/node-fetch/src/index.js:9
    import http from 'node:http';
    ^^^^^^

    SyntaxError: Cannot use import statement outside a module

@glensc
Copy link
Contributor Author

glensc commented Mar 29, 2022

Apparently broken with 9e16443 commit

Unclear what's the commit purpose,
Why no Pull Request? Why no explanation what is the problem to be solved?

Perhaps this repo should be moved to a danger organization, so the community can deal with the maintenance?

@orta
Copy link
Owner

orta commented Mar 29, 2022

Broke by 714f03b and the commit message says what it does - typescript did not build on master when I cloned it

@orta
Copy link
Owner

orta commented Mar 29, 2022

Fixed in 1.5.1, and no, I'm not really into moving to the danger org - that's not really for plugins

@glensc
Copy link
Contributor Author

glensc commented Mar 29, 2022

Confirming fixed with 1.5.1. Thanks!

@orta orta closed this as completed Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants