-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(breadcrumb): [breadcrumb] Add dark theme #2984
feat(breadcrumb): [breadcrumb] Add dark theme #2984
Conversation
WalkthroughThis pull request enhances the breadcrumb component’s styling. It introduces a new CSS variable for the last breadcrumb item's text color and updates existing color variable references. In the LESS files, additional styling is applied to ensure that the last breadcrumb item and its link use the new variable. The changes modify only the visual aspects without altering any control flow or public API declarations. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (5)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis pull request introduces a dark theme to the breadcrumb component in the Tiny Vue library. The changes involve updating the color variables to support the dark theme and modifying the breadcrumb styles to apply these new color variables. Changes
|
@@ -32,10 +32,12 @@ | |||
.@{breadcrumb-prefix-cls}__inner { | |||
font-weight: var(--tv-Breadcrumb-text-font-weight); | |||
text-decoration: none; | |||
color: var(--tv-Breadcrumb-last-text-color); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the new color variable --tv-Breadcrumb-last-text-color
is defined in the theme configuration to avoid potential issues with undefined variables.
|
||
a { | ||
cursor: text; | ||
text-decoration: none; | ||
color: var(--tv-Breadcrumb-last-text-color); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the new color variable --tv-Breadcrumb-last-text-color
is defined in the theme configuration to avoid potential issues with undefined variables.
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit