Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(breadcrumb): [breadcrumb] Add dark theme #2984

Merged
merged 2 commits into from
Mar 3, 2025

Conversation

wuyiping0628
Copy link
Collaborator

@wuyiping0628 wuyiping0628 commented Feb 27, 2025

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Style
    • Enhanced the visual appearance of breadcrumb navigation.
    • Introduced a distinct color for the last breadcrumb item.
    • Updated theme colors for breadcrumb text and separator icons for a more refined look.

@wuyiping0628 wuyiping0628 added the documentation 对文档的改进或补充 label Feb 27, 2025
Copy link

coderabbitai bot commented Feb 27, 2025

Walkthrough

This pull request enhances the breadcrumb component’s styling. It introduces a new CSS variable for the last breadcrumb item's text color and updates existing color variable references. In the LESS files, additional styling is applied to ensure that the last breadcrumb item and its link use the new variable. The changes modify only the visual aspects without altering any control flow or public API declarations.

Changes

File(s) Change Summary
packages/theme/src/breadcrumb/index.less
packages/theme/src/breadcrumb/vars.less
Added a new color variable (--tv-Breadcrumb-last-text-color set to var(--tv-color-text-active-3)) for the last breadcrumb text. In index.less, the last breadcrumb item and its anchor now use this variable. In vars.less, updated the breadcrumb text and separator colors by changing --tv-Breadcrumb-text-color to var(--tv-color-text-control) and --tv-Breadcrumb-separator-icon-color to var(--tv-color-text-placeholder).

Possibly related PRs

Suggested labels

enhancement

Suggested reviewers

  • zzcr

Poem

Oh, what a hop, a new style in view,
A twinkling trail with colors so true!
I’ve painted the last crumb with a vibrant hue,
Bounding through code, joyful and new 🐰✨
In the theme of change, every detail is due!

Hop on, celebrate the art we renew!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 02e08e9 and 1c210a9.

📒 Files selected for processing (2)
  • packages/theme/src/breadcrumb/index.less (1 hunks)
  • packages/theme/src/breadcrumb/vars.less (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (5)
packages/theme/src/breadcrumb/index.less (2)

35-36: Dark Theme Color Applied to Last Breadcrumb Text

The added property color: var(--tv-Breadcrumb-last-text-color); within the last breadcrumb item's inner block ensures that the final breadcrumb text reflects the dark theme styling. This change is straightforward and aligns with the design update.


37-40: Consistent Dark Theme Styling for Last Breadcrumb Link

Within the same block, the anchor element now also utilizes color: var(--tv-Breadcrumb-last-text-color);. This ensures consistency between the text and its corresponding link for the last breadcrumb item.

packages/theme/src/breadcrumb/vars.less (3)

19-19: Updated Breadcrumb Text Color Variable

The property --tv-Breadcrumb-text-color has been updated to var(--tv-color-text-control). This change better aligns the breadcrumb text with dark theme requirements. Be sure that this color adjustment is consistent with the overall theme palette used in the project.


21-21: New Variable for Last Breadcrumb Text Color

A new variable, --tv-Breadcrumb-last-text-color, has been introduced and set to var(--tv-color-text-active-3). This enables distinct styling for the last breadcrumb item under the dark theme, which improves visual hierarchy.


23-23: Separator Icon Color Updated for Enhanced Theming

The update of --tv-Breadcrumb-separator-icon-color to var(--tv-color-text-placeholder) ensures that the separator icon now better fits within the dark theme context. Verify that this placeholder color provides sufficient contrast in all usage scenarios.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added enhancement New feature or request (功能增强) and removed documentation 对文档的改进或补充 labels Feb 27, 2025
Copy link

Walkthrough

This pull request introduces a dark theme to the breadcrumb component in the Tiny Vue library. The changes involve updating the color variables to support the dark theme and modifying the breadcrumb styles to apply these new color variables.

Changes

File Summary
packages/theme/src/breadcrumb/index.less Added new color variables for breadcrumb text and links to support dark theme.
packages/theme/src/breadcrumb/vars.less Updated color variables for text and separator icons to align with the dark theme. Introduced new variables for selected text color.

@@ -32,10 +32,12 @@
.@{breadcrumb-prefix-cls}__inner {
font-weight: var(--tv-Breadcrumb-text-font-weight);
text-decoration: none;
color: var(--tv-Breadcrumb-last-text-color);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the new color variable --tv-Breadcrumb-last-text-color is defined in the theme configuration to avoid potential issues with undefined variables.


a {
cursor: text;
text-decoration: none;
color: var(--tv-Breadcrumb-last-text-color);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the new color variable --tv-Breadcrumb-last-text-color is defined in the theme configuration to avoid potential issues with undefined variables.

@zzcr zzcr merged commit 4dc2f93 into opentiny:dev Mar 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request (功能增强)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants