docs(virtual-scroll-box): virtual-scroll-box doc adapt dark theme #2997
Conversation
WalkthroughThis change updates the CSS styling in two Vue components by replacing the fixed white background of the Changes
Possibly related PRs
Suggested labels
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
examples/sites/demos/pc/app/virtual-scroll-box/table-composition-api.vueOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. examples/sites/demos/pc/app/virtual-scroll-box/table.vueOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🔇 Additional comments (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis pull request updates the documentation for the virtual-scroll-box component to adapt to the dark theme. It modifies the background color of table cells to use a theme variable instead of a hardcoded white color, ensuring compatibility with different themes. Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| @@ -98,7 +98,7 @@ const colStyle = ({ viewRow, viewCol }) => { | |||
| .vs-cell { | |||
| display: table-cell; | |||
| font-size: 12px; | |||
| background-color: white; | |||
| background-color: var(--docs-color-bg); | |||
There was a problem hiding this comment.
Ensure that var(--docs-color-bg) is defined in the theme variables to avoid potential issues with undefined variables in different themes.
| @@ -108,7 +108,7 @@ export default { | |||
| .vs-cell { | |||
| display: table-cell; | |||
| font-size: 12px; | |||
| background-color: white; | |||
| background-color: var(--docs-color-bg); | |||
There was a problem hiding this comment.
Ensure that var(--docs-color-bg) is defined in the theme variables to avoid potential issues with undefined variables in different themes.
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit