MGMT-19545: Replace seed cluster mirror registries in IBI preparation step #727
Conversation
|
@mresvanis: This pull request references MGMT-19545 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-merge-robot
added
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Skipping CI for Draft Pull Request. |
Signed-off-by: Michail Resvanis <[email protected]>
mresvanis
force-pushed
the
ibi-prepare-support-mirrors
branch
from
8108a74 to
55525ef
Compare
openshift-merge-robot
removed
the
needs-rebase
mresvanis
force-pushed
the
ibi-prepare-support-mirrors
branch
from
55525ef to
3d0c994
Compare
| @@ -123,7 +123,7 @@ func getDeploymentFromDeploymentID(deploymentID string) (string, error) { | |||
| } | |||
|
|
|||
| func SetupStateroot(log logr.Logger, ops ops.Ops, ostreeClient ostreeclient.IClient, | |||
| rpmOstreeClient rpmostreeclient.IClient, seedImage, expectedVersion, imageListFile string, ibi bool) error { | |||
| rpmOstreeClient rpmostreeclient.IClient, seedImage, expectedVersion, tmpPath string, ibi bool) error { | |||
There was a problem hiding this comment.
We should probably rename tmpPath to something indicating that this is for IBI. @eranco74 WDYT?
mresvanis
force-pushed
the
ibi-prepare-support-mirrors
branch
2 times, most recently
from
917a6d7 to
947b819
Compare
Signed-off-by: Michail Resvanis <[email protected]>
|
/test all |
|
/test ibu-e2e-flow |
|
@mresvanis: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Background / Context
During the installation step of IBI, after setting up the new stateroot we precache the seed cluster's container images. Although there is support for mirror registries when creating the installation ISO, we currently don't account for the seed image containing pull-specs from mirror registries (i.e. the seed image was generated in a cluster with mirror registries configured). This results in the IBI preparation/installation step to fail when trying to pull images from the release mirror registries of the seed cluster, instead of the target cluster's release mirror registries (or the original release registries if no mirror registries are configured on the target cluster).
Issue / Requirement / Reason for change
We want to support different mirror registry configuration between the seed and the target cluster, in order to enable IBI with seed images generated from disconnected SNO clusters.
Solution / Feature Overview
During the IBI preparation step before precaching the seed cluster's images, we can replace the seed release mirror registry with the target release (mirror) registry. That's exactly what we do in IBU here.
Implementation Details
In order to replace the seed release mirror registry with the target release (mirror) registry, we need the seed's release registry and the target's release registry. We can read the first one from the
manifest.jsonthat's included in the seed image.We can read the second one from the new IBI preparation configuration fieldReleaseRegistry, which we will add during the creation of the installation ISO.Other Information