Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-19545: add optional release registry field to the IBI installation config #9394

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mresvanis
Copy link
Contributor

This change adds the optional ReleaseRegistry field in the IBI installation config. This field is used as a replacement for the seed release registry in the seed cluster's image pull-specs, when the seed container image is generated in a disconnected SNO (i.e. with mirror registries configured).

It is related to: openshift-kni/lifecycle-agent#727.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 23, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 23, 2025

@mresvanis: This pull request references MGMT-19545 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

This change adds the optional ReleaseRegistry field in the IBI installation config. This field is used as a replacement for the seed release registry in the seed cluster's image pull-specs, when the seed container image is generated in a disconnected SNO (i.e. with mirror registries configured).

It is related to: openshift-kni/lifecycle-agent#727.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2025
Copy link
Contributor

openshift-ci bot commented Jan 23, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mresvanis mresvanis force-pushed the mgmt-19545-add-release-registry-imagebased branch from 124da37 to 41c1a6b Compare January 23, 2025 12:32
@mresvanis
Copy link
Contributor Author

/test all

@mresvanis mresvanis marked this pull request as ready for review January 29, 2025 15:49
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2025
@openshift-ci openshift-ci bot requested review from javipolo and tsorya January 29, 2025 15:52
Copy link
Contributor

@eranco74 eranco74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, minor comment

@mresvanis mresvanis force-pushed the mgmt-19545-add-release-registry-imagebased branch from 41c1a6b to f4bd5d6 Compare January 30, 2025 10:02
This change adds the optional `ReleaseRegistry` field in the IBI installation
config. This field is used as a replacement for the seed release registry in the
seed cluster's image pull-specs, when the seed container image is generated in
a disconnected SNO (i.e. with mirror registries configured).

Signed-off-by: Michail Resvanis <[email protected]>
Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

@mresvanis: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-host-groups-ovn-custom-no-upgrade f4bd5d6 link false /test e2e-vsphere-host-groups-ovn-custom-no-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eranco74
Copy link
Contributor

eranco74 commented Feb 5, 2025

/lgtm

@eranco74
Copy link
Contributor

eranco74 commented Feb 5, 2025

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2025
Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2025
@mresvanis
Copy link
Contributor Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants