-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-19545: add optional release registry field to the IBI installation config #9394
base: main
Are you sure you want to change the base?
MGMT-19545: add optional release registry field to the IBI installation config #9394
Conversation
@mresvanis: This pull request references MGMT-19545 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
124da37
to
41c1a6b
Compare
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, minor comment
41c1a6b
to
f4bd5d6
Compare
This change adds the optional `ReleaseRegistry` field in the IBI installation config. This field is used as a replacement for the seed release registry in the seed cluster's image pull-specs, when the seed container image is generated in a disconnected SNO (i.e. with mirror registries configured). Signed-off-by: Michail Resvanis <[email protected]>
@mresvanis: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eranco74 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label acknowledge-critical-fixes-only |
This change adds the optional
ReleaseRegistry
field in the IBI installation config. This field is used as a replacement for the seed release registry in the seed cluster's image pull-specs, when the seed container image is generated in a disconnected SNO (i.e. with mirror registries configured).It is related to: openshift-kni/lifecycle-agent#727.