Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

namespace: Update CleanObjects #891

Merged
merged 1 commit into from
Jan 27, 2025
Merged

namespace: Update CleanObjects #891

merged 1 commit into from
Jan 27, 2025

Conversation

ajaggapa
Copy link
Contributor

CleanObjects uses graceperiod=0 which is not recommended to have smooth deletion of resources. Hence, removing GracePeriodSeconds parameter.

@ajaggapa ajaggapa requested a review from kononovn as a code owner January 23, 2025 15:32
klaskosk
klaskosk approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@klaskosk klaskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
In eco-gotests, only the cnf network team uses this function so there is no risk of this affecting other teams

trewest
trewest approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@trewest trewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@trewest trewest merged commit dd88b10 into openshift-kni:main Jan 27, 2025
3 checks passed
This was referenced Jan 27, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klaskosk klaskosk klaskosk approved these changes

@trewest trewest trewest approved these changes

@sebrandon1 sebrandon1 sebrandon1 approved these changes

@kononovn kononovn Awaiting requested review from kononovn kononovn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajaggapa @sebrandon1 @trewest @klaskosk